remove math dependency; speedups #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tannewt the change from |
tannewt
approved these changes
May 24, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 25, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#33 from kattni/cp-3-update > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#32 from kattni/cp-3-update Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#24 from dhalbert/speedups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathto be able to freeze a number of modules. adafruit_dotstar usesmath.ceil(). I removed that dependency and redid those calculations in specialized ways, which probably sped them up.enumerate()withrange()infill(). This speeds upfill()by 25% or so.In general I am trying to avoid generating garbage. If people were to use integer values a lot instead of tuples, we could preallocate an rgb bytearray and store into it instead of converting the integer value to a tuple.
I experimented with pre-fetching the pixel order values in advance and storing them in instance variables. That would improve
fillby about 4%. I didn't bother with that right now.Tagging @mcscope, who may be interested.